fix: force gzip when no accept encoding header is sent and use identity if gzip is not sent #28026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 flaky tests on run #51660 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay with deprecated delayMs param |
Output
|
|
| network stubbing > intercepting request > delay works correctly with 204 No Content |
Output
|
|
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > opens the run page if a run is clicked |
Test Replay
Output
Screenshots
|
|
scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| scaffolding component testing > create-react-app > scaffolds component testing for Create React App v5 project |
Test Replay
Output
Screenshots
|
|
The first 5 flaky specs are shown, see all 20 specs in Cypress Cloud.
Review all test suite changes for PR #28026 ↗︎
chrisbreiding
requested changes
Oct 11, 2023
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
chrisbreiding
approved these changes
Oct 11, 2023
mschile
reviewed
Oct 11, 2023
ryanthemanuel
commented
Oct 11, 2023
ryanthemanuel
commented
Oct 11, 2023
ryanthemanuel
commented
Oct 11, 2023
mschile
approved these changes
Oct 11, 2023
ryanthemanuel
changed the title
ryanthemanuel
commented
Oct 15, 2023
ryanthemanuel
commented
Oct 15, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Currently, Cypress tries to filter down Accept-Encoding headers to just gzip. This works when the header is present, but when it is blank according to the standards for the header:
Thus, we need to update the logic to specify
identitywhen there is no Accept Encoding header.The problem would manifest itself in the following scenario:
cy.interceptor CSS, font, and image assets in Test Replay)Steps to test
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?